bvaradar commented on a change in pull request #649: migrating kryo's dependency from twitter chill to plain kryo library URL: https://github.com/apache/incubator-hudi/pull/649#discussion_r277905525
########## File path: hoodie-common/src/test/java/com/uber/hoodie/common/util/TestSerializationUtils.java ########## @@ -0,0 +1,70 @@ +/* + * Copyright (c) 2019 Uber Technologies, Inc. ([email protected]) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.uber.hoodie.common.util; + +import java.io.IOException; +import java.util.Arrays; +import java.util.LinkedList; +import org.apache.avro.util.Utf8; +import org.junit.Assert; +import org.junit.Test; + +public class TestSerializationUtils { + + @Test + public void testSerDeser() throws IOException { + // It should handle null object references. + verifyObject(null); + // Object with nulls. + verifyObject(new NonSerializableClass(null)); + // Object with valid values & no default constructor. + verifyObject(new NonSerializableClass("testValue")); + // Object which is of non-serializable class. + verifyObject(new Utf8("test-key")); + // Verify serialization of list. + verifyObject(new LinkedList<>(Arrays.asList(2, 3, 5))); + } + + private <T> void verifyObject(T expectedValue) throws IOException { + byte[] serializedObject = SerializationUtils.serialize(expectedValue); + Assert.assertTrue(serializedObject != null && serializedObject.length > 0); + + final T deserializedValue = SerializationUtils.<T>deserialize(serializedObject); + if (expectedValue == null) { + Assert.assertNull(deserializedValue); + } else { + Assert.assertTrue(expectedValue.equals(deserializedValue)); + } + } + + private static class NonSerializableClass { Review comment: Can you also add a test-case for class with multiple constructors ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
