vinothchandar commented on a change in pull request #657: [HUDI-57] support orc
file
URL: https://github.com/apache/incubator-hudi/pull/657#discussion_r280092593
##########
File path:
hoodie-client/src/main/java/com/uber/hoodie/config/HoodieWriteConfig.java
##########
@@ -369,6 +377,42 @@ public double getLogFileToParquetCompressionRatio() {
return
Double.valueOf(props.getProperty(HoodieStorageConfig.LOGFILE_TO_PARQUET_COMPRESSION_RATIO));
}
+ // orc
+ public String getOrcStringSchema() {
+ return props.getProperty(HoodieStorageConfig.ORC_STRING_SCHEMA);
+ }
+
+ public CompressionKind getOrcCompressionKind() {
+ String compressionName =
props.getProperty(HoodieStorageConfig.ORC_COMPRESS);
+ switch (compressionName.toUpperCase()) {
Review comment:
instead of this switch case, can we do `CompressionKind.valueOf()`, which
should achieve the same?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
