n3nash commented on a change in pull request #660: Rollback inflights when
using Spark [Streaming] write
URL: https://github.com/apache/incubator-hudi/pull/660#discussion_r280568400
##########
File path: hoodie-spark/src/main/java/com/uber/hoodie/DataSourceUtils.java
##########
@@ -149,7 +149,7 @@ public static HoodieWriteClient
createHoodieClient(JavaSparkContext jssc, String
// override above with Hoodie configs specified as options.
.withProps(parameters).build();
- return new HoodieWriteClient<>(jssc, writeConfig);
+ return new HoodieWriteClient<>(jssc, writeConfig, true);
Review comment:
I agree with explicit constructor, I'm merely saying not hardcoded to true,
instead default=true and driven by a config..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
