garyli1019 commented on a change in pull request #795: HUDI-171 delete tmp file
after split merge failure
URL: https://github.com/apache/incubator-hudi/pull/795#discussion_r308426766
##########
File path:
hoodie-common/src/main/java/com/uber/hoodie/common/util/collection/DiskBasedMap.java
##########
@@ -106,7 +106,16 @@ private void initFile(File writeOnlyFileHandle) throws
IOException {
if (!writeOnlyFileHandle.getParentFile().exists()) {
writeOnlyFileHandle.getParentFile().mkdir();
}
- writeOnlyFileHandle.createNewFile();
+ // create the file
+ try {
+ writeOnlyFileHandle.createNewFile();
Review comment:
@n3nash The `writeOnlyFileHandle` in `addShutDownHook` is
`sizeAwareDataOutputStream` type instead of `File` so it doesn't have a
`delete()` method. In `initFile()`, `writeOnlyFileHandle` is a `File` type.
Should we add a variable to this class in order to call it in `addShutDownHook`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
