eisig commented on a change in pull request #805: fix DeltaStreamer writeConfig
URL: https://github.com/apache/incubator-hudi/pull/805#discussion_r309046638
##########
File path:
hoodie-utilities/src/main/java/com/uber/hoodie/utilities/deltastreamer/DeltaSync.java
##########
@@ -453,14 +453,16 @@ private HoodieWriteConfig
getHoodieClientConfig(SchemaProvider schemaProvider) {
HoodieWriteConfig.Builder builder =
HoodieWriteConfig.newBuilder()
.withProps(props)
- .withPath(cfg.targetBasePath)
- .combineInput(cfg.filterDupes, true)
.withCompactionConfig(HoodieCompactionConfig.newBuilder()
+ .fromProperties(HoodieIndexConfig.newBuilder()
Review comment:
yes, It's a litter weird to write fromProps(..) in multiple places.
If move withProps(props) to the end (or after withCompactionConfig), the
props would override the command line args before this method.
Users need to be careful not to put these parameters will appear on the
command line in the configuration file, otherwise the results will make them
feel a bit strange.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
