yanghua commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344613844
########## File path: hudi-bench/src/main/java/org/apache/hudi/bench/writer/DeltaWriter.java ########## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.bench.writer; + +import java.util.HashMap; +import java.util.Map; +import java.util.Properties; +import org.apache.hadoop.conf.Configuration; +import org.apache.hudi.HoodieReadClient; +import org.apache.hudi.HoodieWriteClient; +import org.apache.hudi.WriteStatus; +import org.apache.hudi.avro.model.HoodieCompactionPlan; +import org.apache.hudi.bench.job.HoodieDeltaStreamerWrapper; +import org.apache.hudi.bench.job.HoodieTestSuiteJob.HoodieTestSuiteConfig; +import org.apache.hudi.common.model.HoodieRecord; +import org.apache.hudi.common.table.timeline.HoodieActiveTimeline; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.common.util.collection.Pair; +import org.apache.hudi.config.HoodieCompactionConfig; +import org.apache.hudi.config.HoodieIndexConfig; +import org.apache.hudi.config.HoodieWriteConfig; +import org.apache.hudi.index.HoodieIndex; +import org.apache.hudi.utilities.schema.SchemaProvider; +import org.apache.spark.api.java.JavaRDD; +import org.apache.spark.api.java.JavaSparkContext; + +/** + * A writer abstraction for the Hudi test suite. This class wraps different implementations of writers used to perform + * write operations into the target hudi dataset. Current supported writers are {@link HoodieDeltaStreamerWrapper} + * and {@link HoodieWriteClient} + */ +public class DeltaWriter { + + private HoodieDeltaStreamerWrapper deltaStreamerWrapper; + private HoodieWriteClient writeClient; + private HoodieTestSuiteConfig cfg; + private Option<String> lastCheckpoint; + private HoodieReadClient hoodieReadClient; + private transient Configuration configuration; + private transient JavaSparkContext sparkContext; + + public DeltaWriter(JavaSparkContext jsc, Properties props, HoodieTestSuiteConfig cfg, String schema) throws + Exception { + this(jsc, props, cfg, schema, true); + } + + public DeltaWriter(JavaSparkContext jsc, Properties props, HoodieTestSuiteConfig cfg, String schema, + boolean rollbackInflight) throws Exception { + // We ensure that only 1 instance of HoodieWriteClient is instantiated for a DeltaWriter + /** This does not instantiate a HoodieWriteClient until a + * {@link HoodieDeltaStreamer#commit(HoodieWriteClient, JavaRDD, Option)} is invoked. **/ Review comment: I think we do not recommend using `/** **/` comment mode in the method body. WDYT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
