vinothchandar commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#discussion_r355140925
########## File path: hudi-common/src/main/java/org/apache/hudi/common/bloom/filter/BloomFilterUtils.java ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.bloom.filter; + +/** + * Bloom filter utils + */ +class BloomFilterUtils { + + /** + * Used in computing the optimal Bloom filter size. This approximately equals 0.480453. + */ + private static final double LOG2_SQUARED = Math.log(2) * Math.log(2); + + /** + * @return the bitsize given the total number of entries and error rate + */ + static int getBitSize(int numEntries, double errorRate) { Review comment: and I guess we already checked from your tests that it meets the fp ratio? if so, we are good. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
