[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin

[GitBox]

lamber-ken commented on a change in pull request #1290: [HUDI-584] Relocate 
spark-avro dependency by maven-shade-plugin
URL: https://github.com/apache/incubator-hudi/pull/1290#discussion_r372605766
 
 

 ##########
 File path: 
hudi-cli/src/main/java/org/apache/hudi/cli/commands/HoodieLogFileCommand.java
 ##########
 @@ -104,7 +104,7 @@ public String showLogFileCommits(
           try {
             instantTime = 
n.getLogBlockHeader().get(HeaderMetadataType.INSTANT_TIME);
             if (instantTime == null) {
-              throw new Exception("Invalid instant time " + instantTime);
 
 Review comment:
   @n3nash thanks for your comment, IMO, it's a minor change (which has no 
function impact) may be no need separate PR. 
   
   For the minor change: The `instantTime` variable is known to be null.
   ```
   "Invalid instant time " + null
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services