[GitHub] [hudi] XuQianJin-Stars commented on a change in pull request #4752: [WIP][HUDI-3088] Use Spark 3.2 as default Spark version

[GitBox]

XuQianJin-Stars commented on a change in pull request #4752:
URL: https://github.com/apache/hudi/pull/4752#discussion_r802433824



##########
File path: 
hudi-utilities/src/test/java/org/apache/hudi/utilities/testutils/UtilitiesTestBase.java
##########
@@ -410,6 +411,16 @@ public static String toJsonString(HoodieRecord hr) {
       return 
records.stream().map(Helpers::toJsonString).toArray(String[]::new);
     }
 
+    public static Tuple2<String, String>[] 
jsonifyRecordsByPartitions(List<HoodieRecord> records, int partitions) {

Review comment:
       > java class `org.apache.hudi.common.util.collection.Pair` is preferred 
here over Tuple2
   
   
![image](https://user-images.githubusercontent.com/10494131/153163154-a2a567da-5c62-450e-9ed7-87ac3223409a.png)
   
   The methods exposed here require an array of Tuple2 as input parameters.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org