lamber-ken commented on issue #1304: [MINOR] Replace Thread.sleep with TimeUnit*
URL: https://github.com/apache/incubator-hudi/pull/1304#issuecomment-582627717
 
 
   > IMO anything that needs some kind of subjective debate, cannot be MINOR..
   > 
   > @lamber-ken For these kinds of PRs, can we first check with one of the 
commiters or engage on a JIRA. I feel we need not do this change
   
   Okay, thanks. 
   
   `TimeUnit` gives us a readability improvement, we no need to multiplied by 
1000.
   
![image](https://user-images.githubusercontent.com/20113411/73885833-6df71580-48a3-11ea-96ac-be3e6ed19fda.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to