vinothchandar commented on a change in pull request #1149: [WIP] [HUDI-472]
Introduce configurations and new modes of sorting for bulk_insert
URL: https://github.com/apache/incubator-hudi/pull/1149#discussion_r376236746
##########
File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
##########
@@ -381,20 +384,30 @@ public static SparkConf registerClasses(SparkConf conf) {
}
}
+ private BulkInsertMapFunction<T> getBulkInsertMapFunction(
Review comment:
I was looking at this for a different JIRA. but having a class for
BulkInsertMapfunction seems like an overkill? Can we just replace with lambdas
and kill the class ?
eg, in the code on master, just change to below
```
JavaRDD<WriteStatus> writeStatusRDD = repartitionedRecords
.mapPartitionsWithIndex((partition, recordItr) ->
new CopyOnWriteLazyInsertIterable<>(recordItr, config,
commitTime, table, fileIDPrefixes.get(partition)), true)
.flatMap(List::iterator);
```
if you agree, just do it in the PR.. that way I wont introduce an
unnecessary rebase for you :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
