prashantwason commented on pull request #4274:
URL: https://github.com/apache/hudi/pull/4274#issuecomment-1069818077


   @yihua  @nsivabalan 
   
   I think this commit broke metrics for usage like this:
   
    HoodieMetricsConfig.Builder metricsConfig = HoodieMetricsConfig.newBuilder()
         .withExecutorMetrics(true).on(true);
   
       HoodieWriteConfig writeConfig = 
HoodieWriteConfig.newBuilder().withPath("/tmp").forTable(tableName)
           .withMetricsConfig(metricsConfig.build())
           
.withMetricsGraphiteConfig(HoodieMetricsGraphiteConfig.newBuilder().usePrefix(metricPrefix).build())
           .build();
   
   I end up with commonMetricPrefix as "" in my runs. 
   
   Also I do not see any setter for METRICS_REPORTER_PREFIX in 
HoodieMetricsConfig.Builder.
   
   How are we to use this correctly? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to