smarthi commented on a change in pull request #1350: [HUDI-629]: Replace
Guava's Hashing with an equivalent in NumericUtils.java
URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r382958076
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/minicluster/HdfsTestService.java
##########
@@ -66,7 +66,7 @@ public Configuration getHadoopConf() {
}
public MiniDFSCluster start(boolean format) throws IOException {
- Preconditions.checkState(workDir != null, "The work dir must be set before
starting cluster.");
+ Objects.requireNonNull(workDir, "The work dir must be set before starting
cluster.");
Review comment:
For this null check, its unnecessary - there is a checkState in
ValidationUtils to check other boolean conditions. But null check, its fine to
use Objects.checkNotNull()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
