ramachandranms commented on a change in pull request #1347: [HUDI-627]
Aggregate code coverage and publish to codecov.io during CI
URL: https://github.com/apache/incubator-hudi/pull/1347#discussion_r383500368
##########
File path: pom.xml
##########
@@ -278,8 +276,6 @@
<goal>report</goal>
</goals>
<configuration>
- <!-- Sets the path to the file which contains the execution
data. -->
-
<dataFile>${project.build.directory}/coverage-reports/jacoco-ut.exec</dataFile>
Review comment:
1. This seems to be specific to how sonarqube works and we don't use
sonar/sonarqube for aggregation
2. [This](https://github.com/jacoco/jacoco/wiki/MavenMultiModule#usage) is
the recommendation from official jacoco documentation, which I have followed in
this PR.
I did try out the sonar documentation on a test project locally and couldn't
make it to work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
