garyli1019 commented on a change in pull request #1352: [HUDI-625] Fixing
performance issues around DiskBasedMap & kryo
URL: https://github.com/apache/incubator-hudi/pull/1352#discussion_r383579593
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/util/SerializationUtils.java
##########
@@ -121,50 +116,16 @@ Object deserialize(byte[] objectData) {
public Kryo newKryo() {
- Kryo kryo = new KryoBase();
+ Kryo kryo = new Kryo();
// ensure that kryo doesn't fail if classes are not registered with kryo.
kryo.setRegistrationRequired(false);
// This would be used for object initialization if nothing else works
out.
- kryo.setInstantiatorStrategy(new
org.objenesis.strategy.StdInstantiatorStrategy());
+ kryo.setInstantiatorStrategy(new Kryo.DefaultInstantiatorStrategy(new
StdInstantiatorStrategy()));
// Handle cases where we may have an odd classloader setup like with
libjars
// for hadoop
kryo.setClassLoader(Thread.currentThread().getContextClassLoader());
return kryo;
}
- private static class KryoBase extends Kryo {
- @Override
- protected Serializer newDefaultSerializer(Class type) {
Review comment:
The default is `FieldSerializer` and the description of
setIgnoreSyntheticFields is `Controls if synthetic fields are serialized.
Default is true.` So I think this Override might be unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
