lamber-ken edited a comment on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo URL: https://github.com/apache/incubator-hudi/pull/1351#issuecomment-590634434 > response -> the StdInstantiatorStrategy will allow kryo to fall back to Java Serde, is that what we want ? Hi @n3nash, By default, an instantiator is returned that uses reflection if the class has a zero argument constructor, an exception is thrown. If a `setInstantiatorStrategy(InstantiatorStrategy)` is set, it will be used instead of throwing an exception. More, the key point is the previous KryoBase in `org.apache.hudi.common.util.SerializationUtils` was used in a wrong way. The "super.getInstantiatorStrategy().newInstantiatorOf(type).newInstance();", this will cause call it each time ![image](https://user-images.githubusercontent.com/20113411/75208580-1ae3f480-57b7-11ea-8f1e-3439f369d92b.png)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services