xushiyan edited a comment on pull request #4012: URL: https://github.com/apache/hudi/pull/4012#issuecomment-1082623653
@xiarixiaoyao thanks for sharing the analysis. sorry haven't been able to catch up on time. You're right; `collect()` happens right after `isEmpty()` or `count()`. A full compute + a cache hit faster than a full compute + a partial compute. In this code path, we should do count(). It does slow down the other case where error is present, but that scenario is not performance-sensitive so I think we should be good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
