alexeykudinkin commented on a change in pull request #5181:
URL: https://github.com/apache/hudi/pull/5181#discussion_r840746511
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/HoodieSparkTypeUtils.scala
##########
@@ -15,13 +15,20 @@
* limitations under the License.
*/
-package org.apache.spark
+package org.apache.spark.sql
-import org.apache.spark.sql.types.{DataType, NumericType, StringType}
+import org.apache.spark.sql.types.{DataType, DecimalType, NumericType,
StringType}
// TODO unify w/ DataTypeUtils
object HoodieSparkTypeUtils {
+ /**
+ * Returns whether this DecimalType is wider than `other`. If yes, it means
`other`
+ * can be casted into `this` safely without losing any precision or range.
+ */
+ def isWiderThan(one: DecimalType, another: DecimalType) =
Review comment:
Yeah, missed in cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
