rkkalluri opened a new pull request #5205:
URL: https://github.com/apache/hudi/pull/5205


   
   
   ## What is the purpose of the pull request
   Switching from non-partitioned to partitioned key gen  is currently not 
throw any exception and dumping partitioned data next to the previously 
unpartitioned data files.
   
   The purpose of this pull request is to valid switching from non-partitioned 
to partitioned key gen mechanism
   
   ## Brief change log
   
     - *HoodieWriterUtils.getOriginKeyGenerator is now modified to return the 
default value for KEYGENERATOR_CLASS_NAME when it is not provided as a config, 
this will allow the validations to correctly catch the invalid key gen switch*
   
   ## Verify this pull request
   
   
   This pull request is a trivial rework / code cleanup without any test 
coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added TestHoodieSparkSqlWriter.testNonpartitonedToDefaultKeyGen to 
verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ x] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to