danny0405 commented on a change in pull request #5210:
URL: https://github.com/apache/hudi/pull/5210#discussion_r841061457
##########
File path:
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java
##########
@@ -256,8 +256,8 @@ public Result inputSplits(
HoodieTimeline archivedCompleteTimeline =
archivedTimeline.getCommitsTimeline().filterCompletedInstants();
if (!archivedCompleteTimeline.empty()) {
Stream<HoodieInstant> instantStream =
archivedCompleteTimeline.getInstants();
- return maySkipCompaction(instantStream)
- .map(instant -> WriteProfiles.getCommitMetadata(tableName, path,
instant, archivedTimeline)).collect(Collectors.toList());
+ return instantStream.map(instant ->
WriteProfiles.getCommitMetadata(tableName, path, instant, archivedTimeline))
+ .collect(Collectors.toList());
Review comment:
You mean for incremental read, the user does not need to read the change
log (or only snapshot is needed) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
