XuQianJin-Stars commented on code in PR #5405:
URL: https://github.com/apache/hudi/pull/5405#discussion_r857245216
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -232,6 +233,8 @@ private FlinkOptions() {
// ------------------------------------------------------------------------
// Write Options
// ------------------------------------------------------------------------
+ public static final ConfigOption<Integer> SINK_PARALLELISM =
FactoryUtil.SINK_PARALLELISM;
+
public static final ConfigOption<String> TABLE_NAME = ConfigOptions
Review Comment:
> Hello, it seems that we want to add a default parallelism to the sink, but
there is already parallelism param named `write.tasks`, can we rename this
param to `write.default_tasks` or something ? And we should add test in
`TestHoodieTableFactory`, before we make agreement, can you revert this PR
first ? Thanks ~
well, let me revert this PR first, Then come to an agreement, sorry
@hehuiyuan my mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
