prashantwason commented on a change in pull request #1073: [HUDI-377] Adding Delete() support to DeltaStreamer URL: https://github.com/apache/incubator-hudi/pull/1073#discussion_r390553417
########## File path: hudi-client/src/test/java/org/apache/hudi/common/HoodieTestDataGenerator.java ########## @@ -435,11 +439,46 @@ public HoodieRecord generateUpdateRecord(HoodieKey key, String commitTime) throw index = (index + 1) % numExistingKeys; kp = existingKeys.get(index); } + existingKeys.remove(kp); Review comment: Shouldn't the remove be with the key rather than the value? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services