nsivabalan commented on code in PR #5462:
URL: https://github.com/apache/hudi/pull/5462#discussion_r861359423
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -386,12 +386,14 @@ public void validateTableProperties(Properties
properties, WriteOperationType op
throw new HoodieException(HoodieTableConfig.POPULATE_META_FIELDS.key() +
" already disabled for the table. Can't be re-enabled back");
}
- // meta fields can be disabled only with SimpleKeyGenerator
- if (!getTableConfig().populateMetaFields()
- &&
!properties.getProperty(HoodieTableConfig.KEY_GENERATOR_CLASS_NAME.key(),
"org.apache.hudi.keygen.SimpleKeyGenerator")
- .equals("org.apache.hudi.keygen.SimpleKeyGenerator")) {
- throw new HoodieException("Only simple key generator is supported when
meta fields are disabled. KeyGenerator used : "
- +
properties.getProperty(HoodieTableConfig.KEY_GENERATOR_CLASS_NAME.key()));
+ // meta fields can be disabled only with SimpleKeyGenerator,
NonPartitioned and ComplexKeyGen.
+ if (!getTableConfig().populateMetaFields()) {
Review Comment:
in spark-sql default key gen is complexKeyGen. thats why I had to make this
fix. we need to revisit that and make simple key gen as default (when user does
not explicitly set one).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
