cuibo01 commented on code in PR #5528: URL: https://github.com/apache/hudi/pull/5528#discussion_r868857643
########## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java: ########## @@ -746,11 +760,11 @@ public static Configuration flatOptions(Configuration conf) { : key; propsMap.put(subKey, value); }); - return fromMap(propsMap); + return Configuration.fromMap(propsMap); } Review Comment: the same code does not need to be repeated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org