danny0405 commented on code in PR #5535: URL: https://github.com/apache/hudi/pull/5535#discussion_r871134983
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java: ########## @@ -1558,13 +1558,15 @@ private void tryUpgrade(HoodieTableMetaClient metaClient, Option<String> instant new UpgradeDowngrade(metaClient, config, context, upgradeDowngradeHelper); if (upgradeDowngrade.needsUpgradeOrDowngrade(HoodieTableVersion.current())) { - // Ensure no inflight commits by setting EAGER policy and explicitly cleaning all failed commits - List<String> instantsToRollback = getInstantsToRollback(metaClient, HoodieFailedWritesCleaningPolicy.EAGER, instantTime); + if (config.getWriteConcurrencyMode().supportsOptimisticConcurrencyControl()) { + // Ensure no inflight commits by setting EAGER policy and explicitly cleaning all failed commits + List<String> instantsToRollback = getInstantsToRollback(metaClient, HoodieFailedWritesCleaningPolicy.EAGER, instantTime); - Map<String, Option<HoodiePendingRollbackInfo>> pendingRollbacks = getPendingRollbackInfos(metaClient); - instantsToRollback.forEach(entry -> pendingRollbacks.putIfAbsent(entry, Option.empty())); + Map<String, Option<HoodiePendingRollbackInfo>> pendingRollbacks = getPendingRollbackInfos(metaClient); + instantsToRollback.forEach(entry -> pendingRollbacks.putIfAbsent(entry, Option.empty())); Review Comment: You mean for LAZY cleaning strategy, we do not rollback failed commits at the start of commits. I totally agree with that. I'm actually confused here whether there are any issues here for metadata table rollback for single-writer mode, if there is no problem, then this patch is an improvement ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org