satishkotha commented on a change in pull request #1368: [HUDI-650] Modify
handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r393275515
##########
File path:
hudi-client/src/test/java/org/apache/hudi/table/TestMergeOnReadTable.java
##########
@@ -1208,6 +1207,83 @@ public void testRollingStatsWithSmallFileHandling()
throws Exception {
}
}
+ @Test
+ public void testHandleUpdateWithMultiplePartitions() throws Exception {
+ HoodieWriteConfig cfg = getConfig(true);
+ try (HoodieWriteClient client = getWriteClient(cfg);) {
+
+ /**
+ * Write 1 (only inserts, written as parquet file)
+ */
+ String newCommitTime = "001";
+ client.startCommitWithTime(newCommitTime);
+
+ List<HoodieRecord> records = dataGen.generateInserts(newCommitTime, 20);
+ JavaRDD<HoodieRecord> writeRecords = jsc.parallelize(records, 1);
+
+ List<WriteStatus> statuses = client.upsert(writeRecords,
newCommitTime).collect();
+ assertNoWriteErrors(statuses);
+
+ HoodieTableMetaClient metaClient = new
HoodieTableMetaClient(jsc.hadoopConfiguration(), cfg.getBasePath());
+ HoodieMergeOnReadTable hoodieTable = (HoodieMergeOnReadTable)
HoodieTable.getHoodieTable(metaClient, cfg, jsc);
+
+ Option<HoodieInstant> deltaCommit =
metaClient.getActiveTimeline().getDeltaCommitTimeline().firstInstant();
+ assertTrue(deltaCommit.isPresent());
+ assertEquals("Delta commit should be 001", "001",
deltaCommit.get().getTimestamp());
+
+ Option<HoodieInstant> commit =
metaClient.getActiveTimeline().getCommitTimeline().firstInstant();
+ assertFalse(commit.isPresent());
+
+ FileStatus[] allFiles =
HoodieTestUtils.listAllDataFilesInPath(metaClient.getFs(), cfg.getBasePath());
+ BaseFileOnlyView roView =
+ new HoodieTableFileSystemView(metaClient,
metaClient.getCommitTimeline().filterCompletedInstants(), allFiles);
+ Stream<HoodieBaseFile> dataFilesToRead = roView.getLatestBaseFiles();
+ assertFalse(dataFilesToRead.findAny().isPresent());
+
+ roView = new HoodieTableFileSystemView(metaClient,
hoodieTable.getCompletedCommitsTimeline(), allFiles);
+ dataFilesToRead = roView.getLatestBaseFiles();
+ assertTrue("should list the parquet files we wrote in the delta commit",
+ dataFilesToRead.findAny().isPresent());
+
+ /**
+ * Write 2 (only updates, written to .log file)
+ */
+ newCommitTime = "002";
+ client.startCommitWithTime(newCommitTime);
+
+ records = dataGen.generateUpdates(newCommitTime, records);
+ writeRecords = jsc.parallelize(records, 1);
+ statuses = client.upsert(writeRecords, newCommitTime).collect();
+ assertNoWriteErrors(statuses);
+
+ /**
+ * Write 3 (only deletes, written to .log file)
+ */
+ final String newDeleteTime = "004";
+ final String partitionPath = records.get(0).getPartitionPath();
+ final String fileId = statuses.get(0).getFileId();
+ client.startCommitWithTime(newDeleteTime);
+
+ List<HoodieRecord> fewRecordsForDelete =
dataGen.generateDeletesFromExistingRecords(records);
+ JavaRDD<HoodieRecord> deleteRDD = jsc.parallelize(fewRecordsForDelete,
1);
+
+ // initialize partitioner
+ hoodieTable.getUpsertPartitioner(new WorkloadProfile(deleteRDD));
+ final List<List<WriteStatus>> deleteStatus =
jsc.parallelize(Arrays.asList(1)).map(x -> {
+ return hoodieTable.handleUpdate(newDeleteTime, partitionPath, fileId,
fewRecordsForDelete.iterator());
+ }).map(x -> (List<WriteStatus>)
HoodieClientTestUtils.collectStatuses(x)).collect();
+
+ // Verify there are errors
+ WriteStatus status = deleteStatus.get(0).get(0);
+ assertTrue(status.hasErrors());
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
