jinxing64 commented on code in PR #5588:
URL: https://github.com/apache/hudi/pull/5588#discussion_r875509658
##########
hudi-spark-datasource/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/HoodieCatalog.scala:
##########
@@ -206,29 +236,17 @@ class HoodieCatalog extends DelegatingCatalogExtension
val newPartitionColumns = partitionColumns
val newBucketSpec = maybeBucketSpec
- val isByPath = isPathIdentifier(ident)
-
- val location = if (isByPath) Option(ident.name()) else
Option(allTableProperties.get("location"))
- val id = ident.asTableIdentifier
-
- val locUriOpt = location.map(CatalogUtils.stringToURI)
- val existingTableOpt = getExistingTableIfExists(id)
- val loc = locUriOpt
- .orElse(existingTableOpt.flatMap(_.storage.locationUri))
- .getOrElse(spark.sessionState.catalog.defaultTablePath(id))
val storage =
DataSource.buildStorageFormatFromOptions(writeOptions.--(needFilterProps))
- .copy(locationUri = Option(loc))
- val tableType =
- if (location.isDefined) CatalogTableType.EXTERNAL else
CatalogTableType.MANAGED
Review Comment:
For the first version of this PR, I construct a whole `HoodieCatalogTable`
first, and then pass it to` HoodieStageTable` and `createHoodieTable` -- but I
think it might be better to only pass the necessary information(location and
table type) to `HoodieStageTable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
