cuibo01 commented on code in PR #5675:
URL: https://github.com/apache/hudi/pull/5675#discussion_r881404844


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/FormatUtils.java:
##########
@@ -241,9 +250,9 @@ public static HoodieMergedLogRecordScanner logScanner(
         .withReadBlocksLazily(writeConfig.getCompactionLazyBlockReadEnabled())
         .withReverseReader(false)
         .withBufferSize(writeConfig.getMaxDFSStreamBufferSize())
-        .withMaxMemorySizeInBytes(writeConfig.getMaxMemoryPerPartitionMerge())
+        .withMaxMemorySizeInBytes(diskMapType == 
ExternalSpillableMap.DiskMapType.ROCKS_DB ? 0 : 
writeConfig.getMaxMemoryPerPartitionMerge())
         .withSpillableMapBasePath(writeConfig.getSpillableMapBasePath())

Review Comment:
   RocksDB has its own memory(default 64MB)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to