cuibo01 commented on code in PR #5675:
URL: https://github.com/apache/hudi/pull/5675#discussion_r883366643
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/FormatUtils.java:
##########
@@ -120,9 +123,12 @@ private static Object getVal(IndexedRecord record, int
pos) {
public static HoodieMergedLogRecordScanner logScanner(
MergeOnReadInputSplit split,
Schema logSchema,
- Configuration config,
- boolean withOperationField) {
Review Comment:
But I think it's better to pass `writeConfig` on, because we can reuse
MergeOnReadInputFormat in the class, avoiding repeated creations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
