cdmikechen commented on code in PR #3391: URL: https://github.com/apache/hudi/pull/3391#discussion_r883598776
########## hudi-common/src/main/java/org/apache/hudi/common/util/Option.java: ########## @@ -76,6 +76,10 @@ public static <T> Option<T> of(T value) { return new Option<>(value); } + public static <T> Option<T> ofNullable(Supplier<? extends T> value) { + return null == value ? empty() : ofNullable(value.get()); + } Review Comment: @xushiyan It's my mistake. Suppliers are supported in java9+, so I want to add it, but I lack consideration when defining methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org