umehrot2 commented on a change in pull request #1421: [HUDI-724] Parallelize
getSmallFiles for partitions
URL: https://github.com/apache/incubator-hudi/pull/1421#discussion_r395545539
##########
File path:
hudi-client/src/main/java/org/apache/hudi/client/HoodieWriteClient.java
##########
@@ -486,11 +486,11 @@ private void
saveWorkloadProfileMetadataToInflight(WorkloadProfile profile, Hood
return updateIndexAndCommitIfNeeded(writeStatusRDD, hoodieTable,
commitTime);
}
- private Partitioner getPartitioner(HoodieTable table, boolean isUpsert,
WorkloadProfile profile) {
+ private Partitioner getPartitioner(HoodieTable table, boolean isUpsert,
WorkloadProfile profile, JavaSparkContext jsc) {
Review comment:
Do we really need all this passing around of `jsc` object ? We can just
directly pass it from within this function right, as its inherited.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
