xushiyan commented on code in PR #5854:
URL: https://github.com/apache/hudi/pull/5854#discussion_r912321105
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/HMSDDLExecutor.java:
##########
@@ -241,20 +248,20 @@ public void dropPartitionsToTable(String tableName,
List<String> partitionsToDro
if (HivePartitionUtil.partitionExists(client, tableName,
dropPartition, partitionValueExtractor, syncConfig)) {
String partitionClause =
HivePartitionUtil.getPartitionClauseForDrop(dropPartition,
partitionValueExtractor, syncConfig);
- client.dropPartition(syncConfig.databaseName, tableName,
partitionClause, false);
+ client.dropPartition(databaseName, tableName, partitionClause,
false);
}
LOG.info("Drop partition " + dropPartition + " on " + tableName);
}
} catch (TException e) {
- LOG.error(syncConfig.databaseName + "." + tableName + " drop partition
failed", e);
- throw new HoodieHiveSyncException(syncConfig.databaseName + "." +
tableName + " drop partition failed", e);
+ LOG.error(databaseName + "." + tableName + " drop partition failed", e);
+ throw new HoodieHiveSyncException(databaseName + "." + tableName + "
drop partition failed", e);
Review Comment:
this could get too verbose when there are 1000s of partitions to sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
