leesf commented on a change in pull request #1418: [HUDI-678] Make config
package spark free
URL: https://github.com/apache/incubator-hudi/pull/1418#discussion_r398467190
##########
File path:
hudi-client/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -503,22 +494,6 @@ public int getJmxPort() {
/**
* memory configs.
*/
- public Double getMaxMemoryFractionPerPartitionMerge() {
- return
Double.valueOf(props.getProperty(HoodieMemoryConfig.MAX_MEMORY_FRACTION_FOR_MERGE_PROP));
- }
-
- public Double getMaxMemoryFractionPerCompaction() {
- return
Double.valueOf(props.getProperty(HoodieMemoryConfig.MAX_MEMORY_FRACTION_FOR_COMPACTION_PROP));
- }
Review comment:
unused methods, remove them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
