xushiyan commented on code in PR #5837: URL: https://github.com/apache/hudi/pull/5837#discussion_r929188666
########## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java: ########## @@ -363,6 +363,12 @@ public Stream<HoodieInstant> getReverseOrderedInstants() { @Override public boolean isBeforeTimelineStarts(String instant) { + Option<HoodieInstant> firstNonSavepointCommit = getFirstNonSavepointCommit(); + return firstNonSavepointCommit.isPresent() + && compareTimestamps(instant, LESSER_THAN, firstNonSavepointCommit.get().getTimestamp()); + } + + public Option<HoodieInstant> getFirstNonSavepointCommit() { Review Comment: should always annotate `@Override` if applicable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org