alexeykudinkin commented on code in PR #5943:
URL: https://github.com/apache/hudi/pull/5943#discussion_r931585204
##########
hudi-spark-datasource/hudi-spark2/src/main/scala/org/apache/spark/sql/adapter/Spark2Adapter.scala:
##########
@@ -122,6 +123,30 @@ class Spark2Adapter extends SparkAdapter {
InterpretedPredicate.create(e)
}
+ override def createHoodieFileScanRDD(sparkSession: SparkSession,
+ readFunction: PartitionedFile =>
Iterator[InternalRow],
+ filePartitions: Seq[FilePartition],
+ readDataSchema: StructType,
+ metadataColumns:
Seq[AttributeReference] = Seq.empty): FileScanRDD = {
+ new Spark2HoodieFileScanRDD(sparkSession, readFunction, filePartitions)
+ }
+
+ override def resolveDeleteFromTable(deleteFromTable: Command,
Review Comment:
I don't see why we can't:
- We get rid of the method completely
- We use `extractCondition` to extract condition and then do everything else
(resolution, etc) in the caller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
