danny0405 commented on code in PR #5716:
URL: https://github.com/apache/hudi/pull/5716#discussion_r931721050
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -364,8 +364,8 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<Boolean>
REFRESH_TIMELINE_SERVER_BASED_ON_LATEST_COMMIT = ConfigProperty
.key("hoodie.refresh.timeline.server.based.on.latest.commit")
- .defaultValue(false)
- .withDocumentation("Refresh timeline in timeline server based on latest
commit apart from timeline hash difference. By default (false), ");
+ .defaultValue(true)
Review Comment:
> hy can't we keep it as false
It is actually hard code to be true before this patch and this config option
is fixed to be effective only after this PR.
Take a look at `TimelineService#refreshTimelineBasedOnLatestCommit`, it's
weird that the member is hard code to be true and there is no way to config it
before this patch, config option
`REFRESH_TIMELINE_SERVER_BASED_ON_LATEST_COMMIT` is totally ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
