xushiyan commented on code in PR #6237:
URL: https://github.com/apache/hudi/pull/6237#discussion_r932742580
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/HoodieWrapperFileSystem.java:
##########
@@ -145,8 +145,11 @@ public static Path convertPathWithScheme(Path oldPath,
String newScheme) {
URI oldURI = oldPath.toUri();
URI newURI;
try {
- newURI = new URI(newScheme, oldURI.getUserInfo(), oldURI.getHost(),
oldURI.getPort(), oldURI.getPath(),
- oldURI.getQuery(), oldURI.getFragment());
+ newURI = new URI(newScheme,
+ oldURI.getAuthority(),
+ oldURI.getPath(),
+ oldURI.getQuery(),
+ oldURI.getFragment());
Review Comment:
can you help clarify the impact of this change pls? it fixes s3
compatibilities, but will it stay fully compatible with previous method usage?
not very clear about the nuances of these 2 APIs, and how it caused problems
with s3. would like to have some detailed info in the PR to analyze the impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
