[GitHub] [hudi] danny0405 commented on a diff in pull request #6246: Be able to disable precombine field when table schema contains a field named ts

[GitBox]

danny0405 commented on code in PR #6246:
URL: https://github.com/apache/hudi/pull/6246#discussion_r937547056


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java:
##########
@@ -147,7 +147,7 @@ private void sanityCheck(Configuration conf, ResolvedSchema 
schema) {
         throw new HoodieValidationException("Option '" + 
FlinkOptions.PRECOMBINE_FIELD.key()
             + "' is required for payload class: " + 
DefaultHoodieRecordPayload.class.getName());
       }
-      if 
(preCombineField.equals(FlinkOptions.PRECOMBINE_FIELD.defaultValue())) {
+      if (preCombineField.equals(FlinkOptions.PRECOMBINE_FIELD.defaultValue()) 
|| preCombineField.equals(FlinkOptions.NO_PRE_COMBINE)){
         conf.setString(FlinkOptions.PRECOMBINE_FIELD, 
FlinkOptions.NO_PRE_COMBINE);

Review Comment:
   Then we can do such logic:
   else if (!preCombineField.equals(FlinkOptions.NO_PRE_COMBINE)) {
       throw new HoodieValidationException("Field " + preCombineField + " does 
not exist in the table schema."
               + "Please check '" + FlinkOptions.PRECOMBINE_FIELD.key() + "' 
option.");
   }



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org