YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r940847507
########## hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystPlanUtils.scala: ########## @@ -52,8 +57,56 @@ abstract class HoodieSpark3CatalystPlanUtils extends HoodieCatalystPlansUtils { } } - override def toTableIdentifier(relation: UnresolvedRelation): TableIdentifier = { - relation.multipartIdentifier.asTableIdentifier + override def resolve(spark: SparkSession, relation: UnresolvedRelation): Option[CatalogTable] = { Review Comment: sure. see the user case: https://github.com/apache/hudi/issues/6223. If we use the three part `catalog.database.table` in spark3.x like , we need the ability to parse these identifiers. And, the reason that Spark's default `ResolveRelations` can't work is, the `UnresolvedRelation` hasn't resolved when apply the cases/rules in `HoodieAnalysis`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org