YannByron commented on code in PR #6264:
URL: https://github.com/apache/hudi/pull/6264#discussion_r943051969
##########
hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystPlanUtils.scala:
##########
@@ -52,8 +57,56 @@ abstract class HoodieSpark3CatalystPlanUtils extends
HoodieCatalystPlansUtils {
}
}
- override def toTableIdentifier(relation: UnresolvedRelation):
TableIdentifier = {
- relation.multipartIdentifier.asTableIdentifier
+ override def resolve(spark: SparkSession, relation: UnresolvedRelation):
Option[CatalogTable] = {
Review Comment:
> My suggestions are basically following: 1. 2.
your suggestions can also work. Still inject the rules to `Resolution`
batch but force to ask all the relation is resolved.
but for the time travel case you also mention, we have to resolve the
`UnresolvedRelation` inside of Hudi by this resolution logic in this pr.
Let hudi get rid of all the resolution logics, make all the `LogicalPlan` be
resolved and optimized correctly. I suggest to create an other pr to trace. And
this pr just makes the identifier with catalog can work in hudi.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
