alexeykudinkin commented on code in PR #6550:
URL: https://github.com/apache/hudi/pull/6550#discussion_r961841532
##########
pom.xml:
##########
@@ -1938,7 +1910,8 @@
<scala.version>${scala12.version}</scala.version>
<scala.binary.version>2.12</scala.binary.version>
<hudi.spark.module>hudi-spark3.2.x</hudi.spark.module>
- <hudi.spark.common.module>hudi-spark3-common</hudi.spark.common.module>
+ <!-- This glob has to include hudi-spark3-common,
hudi-spark3.2plus-common -->
+
<hudi.spark.common.modules.glob>hudi-spark3*-common</hudi.spark.common.modules.glob>
Review Comment:
Yeah, not a big fan of globbing (it's quite brittle). Let me try to have
separate module (the only reason i opted for globbing initially was b/c wasn't
sure if Maven will be able to handle an empty clause, since for ex, this
parameter for Spark 2 and 3.1 would be empty)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
