voonhous commented on code in PR #6566:
URL: https://github.com/apache/hudi/pull/6566#discussion_r964355713


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/HoodieFlinkClusteringJob.java:
##########
@@ -335,5 +391,17 @@ public void shutdownAsyncService(boolean error) {
     public void shutDown() {
       shutdownAsyncService(false);
     }
+
+    /**
+     * Execute a dummy pipeline to prevent "no execute() calls" exceptions 
from being thrown if
+     * clustering is not performed.
+     */

Review Comment:
   Updated the code for both `compactor` and `clusteringjob` to include a catch 
block like this:
   
   ```java
   try {
     compactionScheduleService.compact();
   } catch (ApplicationExecutionException aee) {
     if (aee.getMessage().contains(NO_EXECUTE_CALL_KEYWORD)) {
       LOG.info("Compaction is not performed");
     } else {
       throw aee;
     }
   } catch (Exception e) {
     LOG.error("Got error running delta sync once. Shutting down", e);
     throw e;
   } finally {
     LOG.info("Shut down hoodie flink compactor");
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to