nsivabalan commented on code in PR #5478: URL: https://github.com/apache/hudi/pull/5478#discussion_r965436152
########## hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java: ########## @@ -539,4 +543,19 @@ public void handle(@NotNull Context context) throws Exception { } } } + + /** + * Determine whether to throw an exception when local view of table's timeline is behind that of client's view. + */ + private boolean shouldThrowExceptionIfLocalViewBehind(HoodieTimeline localTimeline, String lastInstantTs) { Review Comment: shouldn't we call this from within isLocalViewBehind(). already we have timline there right. we don't need to re-instantiate the timeline again in L507. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org