dongkelun commented on code in PR #5478:
URL: https://github.com/apache/hudi/pull/5478#discussion_r965460402
##########
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java:
##########
@@ -539,4 +543,19 @@ public void handle(@NotNull Context context) throws
Exception {
}
}
}
+
+ /**
+ * Determine whether to throw an exception when local view of table's
timeline is behind that of client's view.
+ */
+ private boolean shouldThrowExceptionIfLocalViewBehind(HoodieTimeline
localTimeline, String lastInstantTs) {
Review Comment:
My idea is to judge whether to throw an exception if `isLocalViewBehind`
returns true. Because the `isLocalViewBehind` method is also used in the
`syncIfLocalViewBehind` method, I am not sure whether it is appropriate to
directly modify the logic of the `isLocalViewBehind` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
