jsbali commented on code in PR #6502:
URL: https://github.com/apache/hudi/pull/6502#discussion_r965477406


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/metrics/HoodieMetricsConfig.java:
##########
@@ -83,6 +83,11 @@ public class HoodieMetricsConfig extends HoodieConfig {
       .sinceVersion("0.7.0")
       .withDocumentation("");
 
+  public static final ConfigProperty<Boolean> LOCK_METRICS_ENABLE = 
ConfigProperty
+      .key(METRIC_PREFIX + ".lock.enable")
+      .defaultValue(false)

Review Comment:
   Ok so we want the default to correspond to metrics.on and false if set 
explicitly. Is my understanding correct



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to