alexeykudinkin commented on code in PR #6046:
URL: https://github.com/apache/hudi/pull/6046#discussion_r971287163
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/clustering/run/strategy/SparkSortAndSizeExecutionStrategy.java:
##########
@@ -52,6 +55,27 @@ public SparkSortAndSizeExecutionStrategy(HoodieTable table,
super(table, engineContext, writeConfig);
}
+ @Override
+ public HoodieData<WriteStatus> performClusteringWithRecordsRow(Dataset<Row>
inputRecords, int numOutputGroups,
+ String
instantTime, Map<String, String> strategyParams, Schema schema,
+
List<HoodieFileGroupId> fileGroupIdList, boolean preserveHoodieMetadata) {
+ LOG.info("Starting clustering for a group, parallelism:" + numOutputGroups
+ " commit:" + instantTime);
+ HoodieWriteConfig newConfig = HoodieWriteConfig.newBuilder()
+ .withBulkInsertParallelism(numOutputGroups)
+ .withProps(getWriteConfig().getProps()).build();
+
+ boolean shouldPreserveHoodieMetadata = preserveHoodieMetadata;
Review Comment:
That should be decided wherever we use it. But we shouldn't be overriding
one w/ another here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
