parisni commented on PR #6537:
URL: https://github.com/apache/hudi/pull/6537#issuecomment-1249828151
Agreed, I will close this
On Thu, 2022-09-15 at 22:47 -0700, Shiyan Xu wrote:
> @xushiyan commented on this pull request.
>
>
>
> > @@ -286,7 +286,11 @@ private boolean syncSchema(String tableName,
> > boolean tableExists, boolean useRea
> config.getBooleanOrDefault(HIVE_SUPPORT_TIMESTAMP_TYPE));
> if (!schemaDiff.isEmpty()) {
> LOG.info("Schema difference found for " + tableName);
> - syncClient.updateTableSchema(tableName, schema);
> + if (!schemaDiff.getAddColumnTypes().isEmpty() ||
> !schemaDiff.getUpdateColumnTypes().isEmpty()) {
>
> we should always keep schema up to date. when later data written with
> old schema,
>
https://hudi.apache.org/docs/configurations#hoodiedatasourcewritereconcileschema
> this config is to adapt the data into the new schema. so i don't
> think we should skip update schema
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
