parisni commented on code in PR #6580:
URL: https://github.com/apache/hudi/pull/6580#discussion_r973465697


##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -735,6 +735,34 @@ public final Stream<HoodieFileGroup> 
getAllFileGroups(String partitionStr) {
     return getAllFileGroupsIncludingReplaced(partitionStr).filter(fg -> 
!isFileGroupReplaced(fg));
   }
 
+  @Override
+  public final Stream<Pair<String, List<HoodieFileGroup>>> 
getAllFileGroups(List<String> partitionStr) {
+    return getAllFileGroupsIncludingReplaced(partitionStr)
+        .map(pair -> Pair.of(pair.getLeft(), 
pair.getRight().stream().filter(fg -> 
!isFileGroupReplaced(fg)).collect(Collectors.toList())));
+  }
+
+  private Stream<Pair<String, List<HoodieFileGroup>>> 
getAllFileGroupsIncludingReplaced(final List<String> partitionStrList) {
+    try {

Review Comment:
   That make sense



##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -735,6 +735,34 @@ public final Stream<HoodieFileGroup> 
getAllFileGroups(String partitionStr) {
     return getAllFileGroupsIncludingReplaced(partitionStr).filter(fg -> 
!isFileGroupReplaced(fg));
   }
 
+  @Override
+  public final Stream<Pair<String, List<HoodieFileGroup>>> 
getAllFileGroups(List<String> partitionStr) {
+    return getAllFileGroupsIncludingReplaced(partitionStr)
+        .map(pair -> Pair.of(pair.getLeft(), 
pair.getRight().stream().filter(fg -> 
!isFileGroupReplaced(fg)).collect(Collectors.toList())));
+  }
+
+  private Stream<Pair<String, List<HoodieFileGroup>>> 
getAllFileGroupsIncludingReplaced(final List<String> partitionStrList) {
+    try {

Review Comment:
   That makes sense



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to