[GitHub] [hudi] rahil-c commented on pull request #6688: Fix AWSDmsAvroPayload#combineAndGetUpdateValue when using MOR snapshot query after delete operations

[GitBox]

rahil-c commented on PR #6688:
URL: https://github.com/apache/hudi/pull/6688#issuecomment-1249916684

   @yihua Was able to add test which exposed the constructor issue as well as 
the same `combineAndGetValue` issue  that aws customer saw 
   
   ```
   Caused by: java.util.NoSuchElementException: No value present in Option
       at org.apache.hudi.common.util.Option.get(Option.java:88)
       at 
org.apache.hudi.common.model.AWSDmsAvroPayload.<init>(AWSDmsAvroPayload.java:52)
       ... 35 more
   ```
   
   ```
   ava.util.NoSuchElementException: No value present in Option
        at org.apache.hudi.common.util.Option.get(Option.java:89)
        at 
org.apache.hudi.common.model.AWSDmsAvroPayload.combineAndGetUpdateValue(AWSDmsAvroPayload.java:90)
        at 
org.apache.hudi.common.model.AWSDmsAvroPayload.combineAndGetUpdateValue(AWSDmsAvroPayload.java:84)
        at 
org.apache.hudi.common.model.TestAWSDmsAvroPayload.testDeleteWithEmptyPayLoad(TestAWSDmsAvroPayload.java:123)
   ``` 
   
   with this fix both issues are gone. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org