yihua commented on code in PR #6349: URL: https://github.com/apache/hudi/pull/6349#discussion_r973524308
########## hudi-cli/src/test/java/org/apache/hudi/cli/integ/ITTestRepairsCommand.java: ########## @@ -102,9 +104,12 @@ public void init() throws Exception { cowTable.withInserts(HoodieTestDataGenerator.DEFAULT_SECOND_PARTITION_PATH, "4", hoodieRecords1) .withInserts(HoodieTestDataGenerator.DEFAULT_THIRD_PARTITION_PATH, "6", hoodieRecords1); + cowTable.withInserts(HoodieTestDataGenerator.NO_PARTITION_PATH, "9", hoodieRecords1); Review Comment: This does not properly generate the non-partitioned table for testing. You need to create a separate table path and `HoodieSparkWriteableTestTable` instance to generate separate non-partitioned tables for COW and MOR. If you're not sure about how to implement this, I can help you with tests, so we can land it soon for the 0.12.1 release. ``` String cowNonPartitionedTablePath = Paths.get(basePath, HoodieTableType.COPY_ON_WRITE.name()).toString(); HoodieSparkWriteableTestTable cowNonPartitionedTable = ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org